HBASE-27717 Add rsgroup name for dead region servers on master UI #5330

xieyupei · 2023-07-23T08:51:55Z

No description provided.

Apache-HBase · 2023-07-23T09:15:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		8m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	dupname asflicense javac spotless
uname	Linux a2fead542e15 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2023-07-23T13:12:22Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

+                inMgr = master.getRSGroupInfoManager();
+        }
+        for (ServerName deadServerName: deadServerNames) {
+            String rsGroupName = "default";


RSGroupInfo.DEFAULT_GROUP

great，thank you

sunhelly · 2023-07-23T13:14:25Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/MasterStatusTmpl.jamon

    </%java>
    <tr>
    	<th></th>
        <td><% deadServerName %></td>
        <td><% deadServerUtil.getTimeOfDeath(deadServerName) %></td>
+        <%if !master.isInMaintenanceMode() && master.getMasterCoprocessorHost() != null %>


Set the rsGroupName be null as default, and here use condition if(rsGroupName!=null)

Apache-HBase · 2023-07-23T13:43:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
-1 ❌	unit	266m 4s	hbase-server in the patch failed.
		277m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	javac javadoc unit
uname	Linux 1bf0d4738a49 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Temurin-1.8.0_352-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/testReport/
Max. process+thread count	4227 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-23T13:46:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 51s	master passed
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 8s	the patch passed
+1 💚	javadoc	0m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	267m 12s	hbase-server in the patch passed.
		281m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	javac javadoc unit
uname	Linux a78ab69aac8c 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/testReport/
Max. process+thread count	4160 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-23T15:28:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 1s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 51s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 40s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		8m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	dupname asflicense javac spotless
uname	Linux 71afaeae9fec 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-23T19:44:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 11s	the patch passed
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	251m 44s	hbase-server in the patch passed.
		264m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	javac javadoc unit
uname	Linux ba1d94e5e866 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/testReport/
Max. process+thread count	4546 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-07-23T19:56:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 39s	master passed
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
+1 💚	unit	264m 6s	hbase-server in the patch passed.
		275m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5330
Optional Tests	javac javadoc unit
uname	Linux 6376e9420ff3 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `73ea43f`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/testReport/
Max. process+thread count	4411 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5330/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2023-07-24T11:18:46Z

LGTM.
UI changes always need result screenshots, please upload at your convenience, thanks.

xieyupei · 2023-07-24T15:26:06Z

LGTM. UI changes always need result screenshots, please upload at your convenience, thanks.

i am sorry that i don`t know how to upload, is this ok?

) Co-authored-by: xieyupei <xieyupei@meituan.com> Signed-off-by: Xiaolin Ha <haxiaolin@apache.org> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 712254b)

HBASE-27717 Add rsgroup name for dead region servers on master UI

82847f3

sunhelly reviewed Jul 23, 2023

View reviewed changes

fix code to make it compliant

f96839e

xieyupei requested a review from sunhelly July 23, 2023 15:11

sunhelly approved these changes Jul 26, 2023

View reviewed changes

Apache9 approved these changes Aug 13, 2023

View reviewed changes

Apache9 merged commit 712254b into apache:master Aug 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27717 Add rsgroup name for dead region servers on master UI #5330

HBASE-27717 Add rsgroup name for dead region servers on master UI #5330

xieyupei commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

sunhelly Jul 23, 2023

xieyupei Jul 23, 2023

sunhelly Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

sunhelly commented Jul 24, 2023

xieyupei commented Jul 24, 2023

HBASE-27717 Add rsgroup name for dead region servers on master UI #5330

HBASE-27717 Add rsgroup name for dead region servers on master UI #5330

Conversation

xieyupei commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

sunhelly Jul 23, 2023

Choose a reason for hiding this comment

xieyupei Jul 23, 2023

Choose a reason for hiding this comment

sunhelly Jul 23, 2023

Choose a reason for hiding this comment

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

Apache-HBase commented Jul 23, 2023

sunhelly commented Jul 24, 2023

xieyupei commented Jul 24, 2023