HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId #541

rabi-kumar · 2019-08-26T08:53:33Z

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId

…onId

…onId. Improved Formatting

Apache-HBase · 2019-08-26T10:49:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	322	master passed
+1	compile	26	master passed
+1	checkstyle	33	master passed
+1	shadedjars	271	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	24	master passed
0	spotbugs	70	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	67	master passed
		_ Patch Compile Tests _
+1	mvninstall	299	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	32	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	295	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	924	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	82	the patch passed
		_ Other Tests _
+1	unit	116	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		2990

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 72f80246dcb0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `1ea5d8b`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/testReport/
Max. process+thread count	293 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-26T22:39:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	37	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	322	master passed
+1	compile	25	master passed
+1	checkstyle	33	master passed
+1	shadedjars	270	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	24	master passed
0	spotbugs	71	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	68	master passed
		_ Patch Compile Tests _
+1	mvninstall	293	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	32	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	302	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	965	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	22	the patch passed
+1	findbugs	71	the patch passed
		_ Other Tests _
+1	unit	109	hbase-client in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		2980

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux d63915a20824 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `0438fdc`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-27T13:58:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	54	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	353	master passed
+1	compile	28	master passed
+1	checkstyle	34	master passed
+1	shadedjars	279	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	24	master passed
0	spotbugs	74	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	73	master passed
		_ Patch Compile Tests _
+1	mvninstall	302	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	31	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	272	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	994	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	84	the patch passed
		_ Other Tests _
+1	unit	118	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3087

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f0afccca517c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `ec68bf3`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-27T22:50:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	36	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	325	master passed
+1	compile	26	master passed
+1	checkstyle	31	master passed
+1	shadedjars	274	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	master passed
0	spotbugs	71	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	70	master passed
		_ Patch Compile Tests _
+1	mvninstall	295	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	32	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	270	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	918	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	70	the patch passed
		_ Other Tests _
+1	unit	109	hbase-client in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		2919

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 663d2516a891 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `5106f28`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/testReport/
Max. process+thread count	295 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-28T06:20:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	50	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	1	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	420	master passed
+1	compile	29	master passed
+1	checkstyle	38	master passed
+1	shadedjars	351	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	27	master passed
0	spotbugs	86	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	84	master passed
		_ Patch Compile Tests _
+1	mvninstall	380	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	35	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	351	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1185	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	90	the patch passed
		_ Other Tests _
+1	unit	122	hbase-client in the patch passed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		3707

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 798262e8c916 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/testReport/
Max. process+thread count	289 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-28T12:23:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	35	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	343	master passed
+1	compile	26	master passed
+1	checkstyle	33	master passed
+1	shadedjars	288	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	master passed
0	spotbugs	71	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	69	master passed
		_ Patch Compile Tests _
+1	mvninstall	298	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	30	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	273	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	986	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	76	the patch passed
		_ Other Tests _
+1	unit	116	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3033

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux ba45ba6e9136 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `56980fb`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/testReport/
Max. process+thread count	291 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T20:18:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	78	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	373	master passed
+1	compile	25	master passed
+1	checkstyle	34	master passed
+1	shadedjars	300	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	24	master passed
0	spotbugs	78	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	76	master passed
		_ Patch Compile Tests _
+1	mvninstall	341	the patch passed
+1	compile	26	the patch passed
+1	javac	26	the patch passed
+1	checkstyle	33	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	304	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1038	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	22	the patch passed
+1	findbugs	83	the patch passed
		_ Other Tests _
+1	unit	104	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3296

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8c762a06e6e2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `83e7794`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/testReport/
Max. process+thread count	262 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-29T23:51:06Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	32	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	357	master passed
+1	compile	25	master passed
+1	checkstyle	33	master passed
+1	shadedjars	305	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	23	master passed
0	spotbugs	76	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	74	master passed
		_ Patch Compile Tests _
+1	mvninstall	337	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	34	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	303	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1249	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	21	the patch passed
+1	findbugs	78	the patch passed
		_ Other Tests _
+1	unit	112	hbase-client in the patch passed.
+1	asflicense	12	The patch does not generate ASF License warnings.
		3421

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux e30f2ddeb9f8 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `f6a4c66`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/testReport/
Max. process+thread count	263 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-30T06:24:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	41	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	339	master passed
+1	compile	27	master passed
+1	checkstyle	32	master passed
+1	shadedjars	281	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	master passed
0	spotbugs	71	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	68	master passed
		_ Patch Compile Tests _
+1	mvninstall	301	the patch passed
+1	compile	27	the patch passed
+1	javac	27	the patch passed
+1	checkstyle	31	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	289	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	941	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	23	the patch passed
+1	findbugs	74	the patch passed
		_ Other Tests _
+1	unit	108	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		2992

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6357471d1a2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `090c55f`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/testReport/
Max. process+thread count	295 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T14:11:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	53	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	427	master passed
+1	compile	29	master passed
+1	checkstyle	39	master passed
+1	shadedjars	342	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	27	master passed
0	spotbugs	85	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	83	master passed
		_ Patch Compile Tests _
+1	mvninstall	329	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	30	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	282	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	967	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	22	the patch passed
+1	findbugs	75	the patch passed
		_ Other Tests _
+1	unit	111	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3252

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux be9af7fd2ba4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `ee5cf0d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/testReport/
Max. process+thread count	289 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/10/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-08-31T16:38:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	416	master passed
+1	compile	29	master passed
+1	checkstyle	42	master passed
+1	shadedjars	350	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	31	master passed
0	spotbugs	96	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	93	master passed
		_ Patch Compile Tests _
+1	mvninstall	387	the patch passed
+1	compile	30	the patch passed
+1	javac	30	the patch passed
+1	checkstyle	40	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	365	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1238	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	28	the patch passed
+1	findbugs	98	the patch passed
		_ Other Tests _
+1	unit	128	hbase-client in the patch passed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		3787

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 6ad5c16089f5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `b642ee0`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/testReport/
Max. process+thread count	263 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/11/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T13:30:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	76	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	364	master passed
+1	compile	25	master passed
+1	checkstyle	36	master passed
+1	shadedjars	313	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	29	master passed
0	spotbugs	90	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	87	master passed
		_ Patch Compile Tests _
+1	mvninstall	344	the patch passed
+1	compile	29	the patch passed
+1	javac	29	the patch passed
+1	checkstyle	36	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	306	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1067	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	21	the patch passed
+1	findbugs	83	the patch passed
		_ Other Tests _
+1	unit	117	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3355

Subsystem	Report/Notes
Docker	Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux f1e94474c174 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `97fbaa6`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/testReport/
Max. process+thread count	257 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/12/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T17:50:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	34	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	370	master passed
+1	compile	29	master passed
+1	checkstyle	39	master passed
+1	shadedjars	308	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	25	master passed
0	spotbugs	77	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	74	master passed
		_ Patch Compile Tests _
+1	mvninstall	334	the patch passed
+1	compile	25	the patch passed
+1	javac	25	the patch passed
+1	checkstyle	33	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	304	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1048	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	28	the patch passed
+1	findbugs	97	the patch passed
		_ Other Tests _
+1	unit	125	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3306

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3677b57afea5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `345c21d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/testReport/
Max. process+thread count	262 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/13/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-01T23:02:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	405	master passed
+1	compile	30	master passed
+1	checkstyle	43	master passed
+1	shadedjars	365	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	29	master passed
0	spotbugs	98	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	95	master passed
		_ Patch Compile Tests _
+1	mvninstall	402	the patch passed
+1	compile	38	the patch passed
+1	javac	38	the patch passed
+1	checkstyle	47	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	311	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1053	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	21	the patch passed
+1	findbugs	80	the patch passed
		_ Other Tests _
+1	unit	107	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3502

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 909b404469ce 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `a5ef6b2`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/testReport/
Max. process+thread count	263 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/14/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-09-02T06:23:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	411	master passed
+1	compile	28	master passed
+1	checkstyle	39	master passed
+1	shadedjars	336	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	26	master passed
0	spotbugs	85	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	82	master passed
		_ Patch Compile Tests _
+1	mvninstall	415	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	37	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	347	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1210	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	25	the patch passed
+1	findbugs	86	the patch passed
		_ Other Tests _
+1	unit	128	hbase-client in the patch passed.
+1	asflicense	15	The patch does not generate ASF License warnings.
		3728

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 551a230f13cb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `d32bf8d`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/testReport/
Max. process+thread count	292 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/15/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM overall. Left a few minor points. In general, for me it wasn't clear when you're using xxxSame or when you're using xxxEquals.

hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestConnectionId.java

Apache-HBase · 2019-09-02T13:31:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	59	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
+1	test4tests	0	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1	mvninstall	413	master passed
+1	compile	29	master passed
+1	checkstyle	38	master passed
+1	shadedjars	349	branch has no errors when building our shaded downstream artifacts.
+1	javadoc	27	master passed
0	spotbugs	89	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	86	master passed
		_ Patch Compile Tests _
+1	mvninstall	385	the patch passed
+1	compile	28	the patch passed
+1	javac	28	the patch passed
+1	checkstyle	37	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	334	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1154	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1	javadoc	24	the patch passed
+1	findbugs	75	the patch passed
		_ Other Tests _
+1	unit	111	hbase-client in the patch passed.
+1	asflicense	13	The patch does not generate ASF License warnings.
		3544

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/artifact/out/Dockerfile
GITHUB PR	#541
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 3b50c8ee4ad5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-541/out/precommit/personality/provided.sh
git revision	master / `8e8bd8b`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/testReport/
Max. process+thread count	286 (vs. ulimit of 10000)
modules	C: hbase-client U: hbase-client
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-541/16/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

… changes.

rabi-kumar · 2019-09-02T14:43:08Z

@HorizonNet Thankyou for the suggestions. I have made the necessary changes.

HorizonNet

LGTM, will commit it soon.

rabi-kumar added 2 commits August 23, 2019 16:08

HBASE-22886 Code Coverage Improvement: Create Unit Tests for Connecti…

5b29eee

…onId

HBASE-22886 Code Coverage Improvement: Create Unit Tests for Connecti…

a61496e

…onId. Improved Formatting

HorizonNet changed the title ~~Hbase 22886~~ HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId Aug 26, 2019

HorizonNet added the enhancement label Aug 26, 2019

HorizonNet reviewed Sep 2, 2019

View reviewed changes

HBASE-22886 Code Coverage Improvement for ConnectionId with requested…

f15c154

… changes.

HorizonNet approved these changes Sep 2, 2019

View reviewed changes

HorizonNet merged commit 43e732c into apache:master Sep 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId #541

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId #541

rabi-kumar commented Aug 26, 2019

Apache-HBase commented Aug 26, 2019

Apache-HBase commented Aug 26, 2019

Apache-HBase commented Aug 27, 2019

Apache-HBase commented Aug 27, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 29, 2019

Apache-HBase commented Aug 29, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 2, 2019

HorizonNet left a comment

Apache-HBase commented Sep 2, 2019

rabi-kumar commented Sep 2, 2019

HorizonNet left a comment

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId #541

HBASE-22886 Code Coverage Improvement: Create Unit Tests for class ConnectionId #541

Conversation

rabi-kumar commented Aug 26, 2019

Apache-HBase commented Aug 26, 2019

Apache-HBase commented Aug 26, 2019

Apache-HBase commented Aug 27, 2019

Apache-HBase commented Aug 27, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 28, 2019

Apache-HBase commented Aug 29, 2019

Apache-HBase commented Aug 29, 2019

Apache-HBase commented Aug 30, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Aug 31, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 1, 2019

Apache-HBase commented Sep 2, 2019

HorizonNet left a comment

Choose a reason for hiding this comment

Apache-HBase commented Sep 2, 2019

rabi-kumar commented Sep 2, 2019

HorizonNet left a comment

Choose a reason for hiding this comment