review comments

Author: deniskuzZ

standalone-metastore/packaging/src/docker/README.md

@@ -133,10 +133,16 @@ change the `POSTGRES_LOCAL_PATH` to the path of the downloaded jar.
 
 - Metastore with S3 support
 
-Download aws-java-sdk-bundle-xxx.jar and place it under the jars directory:
+Download AWS SDK bundle and place it under the jars directory:
+
+Note: Hadoop 3.4.1 requires both AWS SDK V1 and V2 for its S3A connector:
 wget https://repo1.maven.org/maven2/com/amazonaws/aws-java-sdk-bundle/1.12.770/aws-java-sdk-bundle-1.12.770.jar -P jars/
+wget https://repo1.maven.org/maven2/software/amazon/awssdk/bundle/2.26.19/bundle-2.26.19.jar -P jars/
 
-Add the `fs.s3a.access.key` and `fs.s3a.secret.key` properties in `metastore-site.xml` under the conf directory.
+Then add the following configs to the `metastore-site.xml` under the conf directory:
+- fs.s3a.endpoint
+- fs.s3a.access.key
+- fs.s3a.secret.key
 
 Then,
 ```shell

standalone-metastore/packaging/src/docker/conf/metastore-site.xml

@@ -34,6 +34,10 @@
   </property>
 
   <!--
+    <property>
+      <name>fs.s3a.endpoint</name>
+      <value>s3.us-west-2.amazonaws.com</value>
+    </property>
     <property>
       <name>fs.s3a.access.key</name>
       <value>YOUR_AWS_ACCESS_KEY</value>

standalone-metastore/packaging/src/docker/entrypoint.sh

@@ -25,16 +25,15 @@ set -x
 STAGING_DIR="/tmp/ext-jars"
 
 TOOLS_LIB="${HADOOP_HOME}/share/hadoop/tools/lib"
-COMMON_LIB="${HADOOP_HOME}/share/hadoop/common/lib"
+HIVE_LIB="${HIVE_HOME}/lib/"
 
 # Checks if /tmp/ext-jars is mounted (via Docker volume).
 if [ -d "$STAGING_DIR" ]; then
-  # Check for aws-java-sdk-bundle (Wildcard handles versions)
-  if ls "$STAGING_DIR"/aws-java-sdk-bundle-*.jar 1> /dev/null 2>&1; then
-    echo "--> Installing AWS SDK Bundle..."
-    cp "$STAGING_DIR"/aws-java-sdk-bundle-*.jar "$COMMON_LIB/"
-    echo "--> activating hadoop-aws from tools..."
-    cp "$TOOLS_LIB"/hadoop-aws-*.jar "$COMMON_LIB/"
+  if ls "$STAGING_DIR"/*.jar 1> /dev/null 2>&1; then
+    echo "--> Copying custom jars from volume to Hive..."
+    cp -vf "$STAGING_DIR"/*.jar "$HIVE_LIB/"
+  else
+    echo "--> Volume mounted at $STAGING_DIR, but no jars found."
   fi
 fi