From 67543cceabaee6e0f9a822a179acd402c60c19e1 Mon Sep 17 00:00:00 2001
From: "xikai.wxk" <xikai.wxk@antgroup.com>
Date: Sun, 9 Apr 2023 23:17:50 +0800
Subject: [PATCH] fix: bugs detected by ut

---
 analytic_engine/src/instance/mod.rs   | 3 ++-
 analytic_engine/src/instance/write.rs | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/analytic_engine/src/instance/mod.rs b/analytic_engine/src/instance/mod.rs
index dacb918d8f..fdb06132e2 100644
--- a/analytic_engine/src/instance/mod.rs
+++ b/analytic_engine/src/instance/mod.rs
@@ -127,7 +127,8 @@ impl Drop for SpaceStore {
 
 impl SpaceStore {
     async fn close(&self) -> Result<()> {
-        todo!("close all background jobs");
+        // TODO: close all background jobs.
+        Ok(())
     }
 }
 
diff --git a/analytic_engine/src/instance/write.rs b/analytic_engine/src/instance/write.rs
index d89f75fc0d..56a1bb248b 100644
--- a/analytic_engine/src/instance/write.rs
+++ b/analytic_engine/src/instance/write.rs
@@ -355,6 +355,8 @@ impl<'a> Writer<'a> {
     /// Do the actual write, must called by write worker in write thread
     /// sequentially.
     pub(crate) async fn write(&mut self, request: WriteRequest) -> Result<usize> {
+        self.table_data.metrics.on_write_request_begin();
+
         self.validate_before_write(&request)?;
         let mut encode_ctx = EncodeContext::new(request.row_group);
 
@@ -423,9 +425,9 @@ impl<'a> Writer<'a> {
         encoded_rows: Vec<ByteVec>,
     ) -> Result<()> {
         let sequence = self.write_to_wal(table_data, encoded_rows).await?;
-        let memserializer = MemTableWriter::make(table_data.clone(), self.serializer);
+        let memtable_writer = MemTableWriter::make(table_data.clone(), self.serializer);
 
-        memserializer
+        memtable_writer
             .write(sequence, &row_group, index_in_writer)
             .map_err(|e| {
                 error!(