Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relation between Cluster and Shard seems messy #1053

Closed
Rachelint opened this issue Jul 6, 2023 · 0 comments · Fixed by #1056
Closed

Relation between Cluster and Shard seems messy #1053

Rachelint opened this issue Jul 6, 2023 · 0 comments · Fixed by #1056
Labels
feature New feature or request

Comments

@Rachelint
Copy link
Contributor

Describe This Problem

As I see, Cluster can be seemed as Space in storage engine, and Shard can be seemed as Table.
So call relationship between Cluster and Shard should be similar as Space and Table's, like:

However the operation levels seems messy in current design.

Proposal

Refactor the call path between Cluster and Shard to be similar as Space and Table.

Additional Context

No response
@Rachelint Rachelint added the feature New feature or request label Jul 6, 2023
@Rachelint Rachelint changed the title Desigin of Cluster interface seems messy Relation between Cluster and Shard seems messy Jul 6, 2023
@Rachelint Rachelint mentioned this issue Jul 11, 2023
Merged
Rachelint added a commit that referenced this issue Jul 11, 2023
@Rachelint
feat: split operations of Cluster and Shard, and serialize operat…
6478a83 
…ions of `Shard` (#1056)

## Rationale
Close #1053 

Now, write operations for shard will be performed parallelly in ceresdb
node(e.g. recover, alter tables in shard).
Obviously, those operations should be performed sequentially like what
about table.

## Detailed Changes
+ introduce `Shard` like `Table`.
+ make write operations for shard performing sequentially by adding a
mutex.

## Test Plan
Test manually.
Rachelint added a commit to Rachelint/ceresdb that referenced this issue Jul 11, 2023
@Rachelint
feat: split operations of Cluster and Shard, and serialize operat…
dbf5542 
…ions of `Shard` (apache#1056)

## Rationale
Close apache#1053 

Now, write operations for shard will be performed parallelly in ceresdb
node(e.g. recover, alter tables in shard).
Obviously, those operations should be performed sequentially like what
about table.

## Detailed Changes
+ introduce `Shard` like `Table`.
+ make write operations for shard performing sequentially by adding a
mutex.

## Test Plan
Test manually.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: split operations of Cluster and Shard, and serialize operations of Shard Rachelint/ceresdb
1 participant
@Rachelint