Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for sql supporting #154

Closed
Rachelint opened this issue Jul 27, 2022 · 4 comments
Closed

Tracking issue for sql supporting #154

Rachelint opened this issue Jul 27, 2022 · 4 comments
Labels
A-SQL Area: SQL layer tracking issue Issue tracks progress for something

Comments

@Rachelint
Copy link
Contributor

Rachelint commented Jul 27, 2022

Description

Support for SQL is very important, but it is far from perfect in ceresdb now. Now there are some deficiencies as follow:

  • Tests are not enough.
  • SQL grammar support is not enough.
  • Bugs in supported SQL grammar.
  • The implementation of dialect is too rough(partly due to the insufficient scalability of sqlparser).

Proposal

  • We plan to add and test sqls related to system table,ud,tpch first, and continue to improve after. The main works on this part are extending related sqls, adding testcases and fixing found bugs.
  • About refactoring the parser to support dialect, it seems hard if still using sqlparser crate (see issue) If you have a good idea, you can put the proposal forward.

Additional context

@dust1
Copy link
Contributor

dust1 commented Jul 28, 2022

Maybe CeresDB can fork sqlparser for secondary development on its basis?

@waynexia
Copy link
Member

The sql/parser submod is a kind of hard-fork. So fork and/or wrap our dialect on top of it could be an option. https://github.com/CeresDB/ceresdb/blob/21bc3e51bd03890a2998919b2d405ab3adc1b8b4/sql/src/parser.rs#L374

@Rachelint
Copy link
Contributor Author

@dust1 @waynexia I intend to refactor as #155 temporarily.
But I think it's still no so good.

@jiacai2050
Copy link
Contributor

This issue is kinds of stale, closing since no obvious work need to do now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-SQL Area: SQL layer tracking issue Issue tracks progress for something
Projects
None yet
Development

No branches or pull requests

4 participants