Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance to hybrid storage format #227

Closed
2 of 10 tasks
jiacai2050 opened this issue Aug 30, 2022 · 2 comments
Closed
2 of 10 tasks

Enhance to hybrid storage format #227

jiacai2050 opened this issue Aug 30, 2022 · 2 comments
Assignees
Labels
feature New feature or request

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Aug 30, 2022

Describe This Problem

Hybrid storage format with basic feature is already merged, but there are still things to be done to gain good performance.

Open an new issue to tracking those.

Proposal

Write

  • Support variable-length type for ListArray
  • Support table without tsid, only a row id is required
  • Persist hybrid collapsible info

Read

  • Support timestamp column filter, some extra columns may be needed
  • Support variable-length type for ListArray
  • Enable a total ordering, to support query with pagination

Misc

  • Compaction support
  • Ensure row group size is large enough, in case of list length within same row_id is to small
  • Use dictionary array type to represent non-collapsible columns to reduce memory usage.
  • Benchmark between two format

Additional Context

#77

@ShiKaiWi
Copy link
Member

ShiKaiWi commented Feb 9, 2023

The poc of hybrid storage has finished.

@ShiKaiWi ShiKaiWi closed this as completed Feb 9, 2023
@jiacai2050
Copy link
Contributor Author

Lessons learnt from this feature.

  • Arrow data layout of hybrid storage is same when primary key is tsid, timestamp
  • The only advantage is less disk usage, which can be gained using dictionary compression.
  • Also convert plain arrow data to nested type makes code hard to maintain, and some feature hard to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants