Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test in wal module can be more extensible #386

Closed
Rachelint opened this issue Nov 10, 2022 · 0 comments · Fixed by #387
Closed

Unit test in wal module can be more extensible #386

Rachelint opened this issue Nov 10, 2022 · 0 comments · Fixed by #387
Labels
feature New feature or request

Comments

@Rachelint
Copy link
Contributor

Describe This Problem

Now, the tests code in wal module is so hard code ... It doesn't take full advantage of the WalBuilder trait.
So it can be more extensible after refactoring.

Proposal

Pass the builder to build tests for different implementation of wal.

Additional Context

No response
@Rachelint Rachelint added the feature New feature or request label Nov 10, 2022
@Rachelint Rachelint mentioned this issue Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: wal unit tests. Rachelint/ceresdb
1 participant
@Rachelint