Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential API/storage format breaking change #402

Closed
jiacai2050 opened this issue Nov 17, 2022 · 5 comments
Closed

Potential API/storage format breaking change #402

jiacai2050 opened this issue Nov 17, 2022 · 5 comments
Labels
feature New feature or request

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Nov 17, 2022

Describe This Problem

When release 1.0, breaking change is not acceptable, so we need to

  1. Remove bad design
  2. Add compatible method to old format

This issue is mainly used to collect potential breaking changes

Proposal

As above

Additional Context

Some examples I can think of

@jiacai2050 jiacai2050 added the feature New feature or request label Nov 17, 2022
@jiacai2050 jiacai2050 pinned this issue Nov 17, 2022
@ShiKaiWi
Copy link
Member

ShiKaiWi commented Dec 8, 2022

What I can come up with now includes:

  • Define the custom format for SST (now it is totally a parquet file) for the possible brand-new format in the future;
  • Refactor the manifest implementation because current one is complicated and may not work well with OBKV;

@ShiKaiWi
Copy link
Member

ShiKaiWi commented Dec 8, 2022

One more thing deserved mentioning here, currently the protocol maps the tenant to the schema, which is actually unreasonable.

@jiacai2050
Copy link
Contributor Author

jiacai2050 commented Jan 4, 2023

@ShiKaiWi
Copy link
Member

ShiKaiWi commented Jan 5, 2023

#538 tries to reduce the size of the meta data used in manifest, which may help solve the problem:

Refactor the manifest implementation because current one is complicated and may not work well with OBKV;

@ShiKaiWi
Copy link
Member

All the breaking changes we know are all finished.

@ShiKaiWi ShiKaiWi unpinned this issue Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants