Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serious meta information overwritten bug of distributed wal in cluster mode #441

Closed
Rachelint opened this issue Dec 1, 2022 · 0 comments · Fixed by #422
Closed

Serious meta information overwritten bug of distributed wal in cluster mode #441

Rachelint opened this issue Dec 1, 2022 · 0 comments · Fixed by #422
Labels
bug Something isn't working

Comments

@Rachelint
Copy link
Contributor

Rachelint commented Dec 1, 2022

Describe this problem

If a shard (which is mapped to region in wal) is move between nodes like this:

A --> B --> ... --> A

Then wal module in mode A can't distinguish if the shard has been moved.
This may cause a serious bug:

  • the shard's wal meta information may be modify in other nodes.
  • when it is moved to A(original node), A doesn't know it and think it is same as before it was moved.
  • A persists the old meta information to storage and overwritten the new one which are persisted in other nodes.

Steps to reproduce

  • see test_move_from_nodes of wal/src/tests/read_write.rs in pr.
  • set region_version_3 equal to region_version_1.

Expected behavior

Can run normally in cluster mode.

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant