Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config wal_path under RocksDB of WalStorageConfig #612

Closed
jiacai2050 opened this issue Feb 6, 2023 · 0 comments · Fixed by #629
Closed

Move config wal_path under RocksDB of WalStorageConfig #612

jiacai2050 opened this issue Feb 6, 2023 · 0 comments · Fixed by #629
Assignees
@Rachelint
Labels
breaking-change Contains user-facing changes feature New feature or request

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Feb 6, 2023 •
edited
Loading

Describe This Problem

Currently, wal_path is in analytic, which is not reasonable,

[analytic]
wal_path = "/tmp/xx"
scan_batch_size = 100

Proposal

Put this field in wal_config section.

[analytic.wal_storage]
type = "RocksDB"

[analytic.wal_storage.rocksdb_config]
path = "/tmp/xx"

Additional Context

No response
@jiacai2050 jiacai2050 added the feature New feature or request label Feb 6, 2023
@jiacai2050 jiacai2050 added the breaking-change Contains user-facing changes label Feb 7, 2023
@Rachelint Rachelint mentioned this issue Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rachelint Rachelint

Labels
breaking-change Contains user-facing changes feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: modify wal config Rachelint/ceresdb
2 participants
@jiacai2050 @Rachelint