Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bounds Send and Sync to some traits #70

Closed
waynexia opened this issue Jun 28, 2022 · 1 comment
Closed

Add bounds Send and Sync to some traits #70

waynexia opened this issue Jun 28, 2022 · 1 comment
Labels
feature New feature or request good first issue Good for newcomers

Comments

@waynexia
Copy link
Member

Description

Some common traits don't bound by Send + Sync in definition but are required (every place) where they are used, like WalManager.

Proposal

Bounding those traits:

#[async_trait]
pub trait WalManager: LogWriter + LogReader + Debug + Send + Sync {}

Additional context
@waynexia waynexia added feature New feature or request good first issue Good for newcomers labels Jun 28, 2022
@waynexia
Copy link
Member Author

This has been done in #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@waynexia