Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AlterSchema and AlterOption to data WAL #82

Closed
waynexia opened this issue Jul 4, 2022 · 0 comments · Fixed by #166
Closed

Move AlterSchema and AlterOption to data WAL #82

waynexia opened this issue Jul 4, 2022 · 0 comments · Fixed by #166
Assignees
@waynexia
Labels
A-analytic-engine Area: Analytic Engine feature New feature or request

Comments

@waynexia
Copy link
Member

waynexia commented Jul 4, 2022 •
edited by ShiKaiWi
Loading

Description

AlterSchema and AlterOption are now persisted in the manifest. It would be better to keep manifest simple (only contains SST file information, sequence number, etc.). And schema modification is related to data, putting them in two separate places may bring some problems.

Proposal

Make manifest only to contain create, drop table, and version edit. The new procedure of altering schema and option is:

  • trigger flush
  • persist new schema/option to WAL
  • update OSS metadata (next PR)
  • update manifest to include the DDL record
  • update memory status

A new file that contains "present schema" and "present option" will be persisted to OSS as table's metadata.

Additional context
@waynexia waynexia added the feature New feature or request label Jul 4, 2022
@waynexia waynexia self-assigned this Jul 4, 2022
@waynexia waynexia added the A-analytic-engine Area: Analytic Engine label Jul 20, 2022
@waynexia waynexia moved this to Todo in Distributed CeresDB Jul 26, 2022
@waynexia waynexia mentioned this issue Aug 4, 2022
Merged
@waynexia waynexia moved this from Server Todo to Server In Progress in Distributed CeresDB Aug 4, 2022
Repository owner moved this from Server In Progress to Server Done in Distributed CeresDB Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waynexia waynexia

Labels
A-analytic-engine Area: Analytic Engine feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: persist AlterSchema and AlterOptions to data WAL waynexia/ceresdb
1 participant
@waynexia