Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test_suggest_duration_and_ranges() occasional fail. #1028

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

zouxiang1993
Copy link
Contributor

Rationale

Timestamp::now() produces a random timestamp which leads to occasional test fail.

Detailed Changes

Use a fixed timestamp.

Test Plan

Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I recommend using a more debug-friendly timestamp, like 2023-1-1 00:00:00

analytic_engine/src/sampler.rs Outdated Show resolved Hide resolved
Co-authored-by: Ruixiang Tan <819464715@qq.com>
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanruixiang tanruixiang changed the title fix: test_suggest_duration_and_ranges() occasional fail. fix: test_suggest_duration_and_ranges() occasional fail. Jun 26, 2023
@ShiKaiWi ShiKaiWi merged commit b9e72f8 into apache:main Jun 26, 2023
@zouxiang1993 zouxiang1993 deleted the fix-sampler-test branch June 26, 2023 03:33
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
## Rationale
Timestamp::now() produces a random timestamp which leads to occasional
test fail.

## Detailed Changes
Use a fixed timestamp.

## Test Plan

---------

Co-authored-by: Ruixiang Tan <819464715@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants