refactor: improve the partition compute #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
force-pushed
the
improve-partition-key-compute
branch
from
1151f6d
to
c69833a
Compare
ShiKaiWi
force-pushed
the
improve-partition-key-compute
branch
from
c69833a
to
c9e73f9
Compare
jiacai2050
reviewed
Aug 15, 2023
|
LGTM |
ShiKaiWi
force-pushed
the
improve-partition-key-compute
branch
from
f09e4b1
to
f926f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The previous implementation of computing partition key is coarse, leading to poor performance.
Detailed Changes
Refactor the implementation of computing partition key, and the most of memory allocation is avoided.
Test Plan
Existing unit tests.