Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for distinct #1155

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

jiacai2050
Copy link
Contributor

Rationale

One of our user report follow errors:

{"code":500,"message":"Failed to handle request, err:Rpc error, code:500, message:Failed to execute plan, sql:select  distinct(`app_id`)   from visit where `period` <= 1692147800000 and `period` >= 1692147600000 , err:Internal error, msg:Failed to execute interpreter, err:Failed to execute select, err:Failed to execute logical plan, err:Failed to do physical optimization, err:DataFusion Failed to optimize physical plan, err:Internal error: Unsupported logical plan: Distinct should be replaced to Aggregate. This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker."}

This bug is already fix in main, so add this to ensure it won't break any more.

Detailed Changes

Test Plan

@Rachelint
Copy link
Contributor

LGTM

Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 422bba7 into apache:main Aug 18, 2023
5 checks passed
@jiacai2050 jiacai2050 deleted the fix-distinct branch November 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants