Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deadline check #1159

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: deadline check #1159

merged 1 commit into from
Aug 17, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Aug 17, 2023 •
edited
Loading

Rationale

Use duration_since is vague, large than is more clearly.

Detailed Changes

Test Plan

Manually.

Rachelint
Rachelint approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 7f8faff into apache:main Aug 17, 2023
5 checks passed
@jiacai2050 jiacai2050 deleted the fix-deadline branch August 17, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @Rachelint