Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add metrics for meta data cache hit rate #1188

Merged
merged 2 commits into from
Aug 31, 2023
Merged

chore: add metrics for meta data cache hit rate #1188

merged 2 commits into from
Aug 31, 2023

Conversation

ShiKaiWi
Copy link
Member

Rationale

There is no metrics to report the hit rate for the meta data cache.

Detailed Changes

  • Add counter for the meta data cache hit/miss.
  • Formalize the logs for the sql query and remote engine service query.

Test Plan

Existing tests.

jiacai2050
jiacai2050 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit b0d7c2c into apache:main Aug 31, 2023
5 checks passed
@ShiKaiWi ShiKaiWi deleted the fix-metrics-for-meta-cache branch August 31, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiKaiWi @jiacai2050