refactor: use encoded_size as memory usage #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
force-pushed
the
refactor-skiplist-memory
branch
from
0c9fbfd
to
2adaf77
Compare
jiacai2050
force-pushed
the
refactor-skiplist-memory
branch
from
2adaf77
to
179c4bd
Compare
ShiKaiWi
reviewed
Sep 14, 2023
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
jiacai2050
force-pushed
the
refactor-skiplist-memory
branch
from
67afd93
to
a42e22e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
In one of our cluster, we find the cost of calculate memory usage cost too much CPU, and it's rwlock contention to be blamed.
Detailed Changes
Test Plan