Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the missing example.toml in README-CN #1253

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

zuston
Copy link
Member

@zuston zuston commented Oct 10, 2023

The example.toml is missing in the docs folder, the minimal.toml is valid.

Rationale

example.toml was renamed into minimal.toml

Detailed Changes

change the README-CN's content

Test Plan

The example toml is missing in the docs folder, the minimal.toml is valid.
@CLAassistant
Copy link

CLAassistant commented Oct 10, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanruixiang
Copy link
Member

Thank you very much for your contribution.

@tanruixiang
Copy link
Member

If it's convenient for you, please sign the CLA for PR merging.

@zuston
Copy link
Member Author

zuston commented Oct 10, 2023

If it's convenient for you, please sign the CLA for PR merging.

Done

@tanruixiang tanruixiang changed the title chore: fix the missing example toml chore: fix the missing example.toml in README-CN Oct 10, 2023
@tanruixiang tanruixiang merged commit 99ae6e0 into apache:main Oct 10, 2023
@tanruixiang
Copy link
Member

@zuston Merged in, thanks again for your contribution and welcome to the ceresdb community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants