Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table blacklist not work for write #1507

Merged
merged 5 commits into from
Mar 29, 2024
Merged

fix: table blacklist not work for write #1507

merged 5 commits into from
Mar 29, 2024

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Mar 28, 2024 •
edited by jiacai2050
Loading

Rationale

Table blocking is found disable in grpc write path, that is annoying...
This pr fix it for making us happy when handling the problematic tables in production.

Detailed Changes

  • support table blocking in grpc write path.
  • add related its.

Test Plan

CI

@jiacai2050 jiacai2050 changed the title fix: fix table blocking in grpc write path fix: table blacklist not work for write Mar 29, 2024
jiacai2050
jiacai2050 reviewed Mar 29, 2024
View reviewed changes
integration_tests/sdk/rust/src/main.rs Show resolved Hide resolved
src/proxy/src/write.rs Outdated Show resolved Hide resolved
jiacai2050
jiacai2050 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 9d64fc1 into apache:main Mar 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rachelint @jiacai2050