Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: allow disable wal in standalone mode #1526

Merged
merged 1 commit into from
May 6, 2024
Merged

refactor: allow disable wal in standalone mode #1526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/horaedb/src/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ use cluster::{cluster_impl::ClusterImpl, config::ClusterConfig, shard_set::Shard
use datafusion::execution::runtime_env::RuntimeConfig as DfRuntimeConfig;
use df_operator::registry::{FunctionRegistry, FunctionRegistryImpl};
use interpreters::table_manipulator::{catalog_based, meta_based};
use logger::{info, RuntimeLevel};
use logger::{info, warn, RuntimeLevel};
use meta_client::{meta_impl, types::NodeMetaInfo};
use proxy::{
limiter::Limiter,
Expand Down Expand Up @@ -122,10 +122,7 @@ fn build_engine_runtimes(config: &RuntimeConfig) -> EngineRuntimes {
fn validate_config(config: &Config) {
let is_data_wal_disabled = config.analytic.wal.disable_data;
if is_data_wal_disabled {
let is_cluster = config.cluster_deployment.is_some();
if !is_cluster {
panic!("Invalid config, we can only disable data wal in cluster deployments")
}
warn!("disable data wal may cause data loss, please check whether this configuration is correct")
}
}

Expand Down
Loading