refactor: remove Meta and Wal type params in Instance #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynexia
reviewed
Aug 3, 2022
ygf11
commented
Aug 5, 2022
waynexia
approved these changes
Aug 5, 2022
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* refactor: remove Meta and Wal type params in Instance * refactor: replace ManifestImpl with ManifestRef when build engine * Fix assert obkv in EngineBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #72
Rationale for this change
Make
Instanceand other relative structs more simple.What changes are included in this PR?
Remove Meta and Wal type params in Instance
Are there any user-facing changes?
No
How does this change test
The refactor is tested by the compiler.