feat: add new table_option storage format #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Rachelint
reviewed
Aug 26, 2022
Rachelint
approved these changes
Aug 26, 2022
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* add new table_option: storage format * fix clippy * add integration tests * add storage format in table schema proto * move storage format to table options module * fix clippy * fix CR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #77 (comment)
Rationale for this change
This is the final PR to implement hybrid storage format(with basic feature), a storage format of one table is read from environment variable now, change it to table options
What changes are included in this PR?
Add new table_option:
storage_formatschema.rstotable_options.rs, as it's belong to table's option, not schemaAre there any user-facing changes?
Yes, a new table_option:
storage_format, which could be one of following values:columnar, defaulthybridHow does this change test
Add four cases in
create_tables.sqlFor now, the integration framework cannot flush table, plan to implement it in future, then I can do
selecttest against hybrid storage.