Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collapsible columns supports variable length type #241

Merged
merged 3 commits into from
Sep 19, 2022
Merged

feat: collapsible columns supports variable length type #241

merged 3 commits into from
Sep 19, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Sep 7, 2022

Which issue does this PR close?

Closes #

Rationale for this change

Support variable-length type for ListArray.
refer to #227

What changes are included in this PR?

Hybrid storage supports string column as collapsible column.

Are there any user-facing changes?

No.

How does this change test

Add unit test merge_string_array_with_none_to_list.

@chunshao90 chunshao90 marked this pull request as ready for review September 8, 2022 06:58
@jiacai2050 jiacai2050 changed the title hybrid storage supports string and binary type feat: collapsible columns supports variable length type Sep 9, 2022
@jiacai2050 jiacai2050 self-requested a review September 15, 2022 02:15
analytic_engine/src/sst/parquet/hybrid.rs Show resolved Hide resolved
analytic_engine/src/sst/parquet/encoding.rs Show resolved Hide resolved
analytic_engine/src/sst/parquet/encoding.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Outdated Show resolved Hide resolved
analytic_engine/src/sst/parquet/hybrid.rs Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 7acf41d into apache:main Sep 19, 2022
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* hybrid storage supports string and binary type

* refactor CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants