-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: collapsible columns supports variable length type #241
Merged
jiacai2050
merged 3 commits into
apache:main
from
chunshao90:feat-hybrid-storage-variable-length
Sep 19, 2022
Merged
feat: collapsible columns supports variable length type #241
jiacai2050
merged 3 commits into
apache:main
from
chunshao90:feat-hybrid-storage-variable-length
Sep 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
changed the title
hybrid storage supports string and binary type
feat: collapsible columns supports variable length type
Sep 9, 2022
5 tasks
jiacai2050
requested changes
Sep 15, 2022
jiacai2050
requested changes
Sep 15, 2022
jiacai2050
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chunshao90
added a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* hybrid storage supports string and binary type * refactor CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Support variable-length type for ListArray.
refer to #227
What changes are included in this PR?
Hybrid storage supports string column as collapsible column.
Are there any user-facing changes?
No.
How does this change test
Add unit test
merge_string_array_with_none_to_list
.