refactor: modify exist wal #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
modify-exist-wal
branch
2 times, most recently
from
dcea234
to
33aeeeb
Compare
ShiKaiWi
reviewed
Oct 11, 2022
Rachelint
force-pushed
the
modify-exist-wal
branch
3 times, most recently
from
3e67196
to
26c9963
Compare
ShiKaiWi
reviewed
Oct 13, 2022
…TableData` while open/create/alter table, especially things about manifest.
Rachelint
force-pushed
the
modify-exist-wal
branch
from
ef5e337
to
b1b94df
Compare
ShiKaiWi
approved these changes
Oct 13, 2022
Rachelint
force-pushed
the
modify-exist-wal
branch
from
c33751a
to
0669756
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* add WalLocation. * add scan to WalManager. * unify the variable name to `wal_location`. * make use of the region_id in wal_location. * add `shard_id` in `TableData` and modidy related path to pass it to `TableData` while open/create/alter table, especially things about manifest. * refactor wal's `ScanRequest`. * refactor by cr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #283
Rationale for this change
see #283
What changes are included in this PR?
WalLocationto replace originalRegionId.scanmethod toWalManager.Are there any user-facing changes?
None.
How does this change test
Test by exist ut.