feat: add TabelCreator/TableDroper for executing create/drop table #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Rachelint
reviewed
Oct 14, 2022
ShiKaiWi
force-pushed
the
feat-impl-create-drop-table
branch
from
c5ceabf
to
4f543f9
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…pache#303) * feat: add TabelCreator/TableDroper for executing create/drop table * chore: replace table creator/dropper with Manipulator * chore: release disk quota before recover cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #235
Rationale for this change
Refer to #235
What changes are included in this PR?
Add
TableCreator/TableDropperto Create/Drop interpreter so that we can choose different implements of create/drop table. After this PR, two kinds of implementations will be provided:catalog_basedandmeta_based.Are there any user-facing changes?
None.
How does this change test
Existing UT.