Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: set correct version and let member packages inherit it #325

Merged
merged 5 commits into from
Oct 20, 2022

Conversation

archerny
Copy link
Contributor

@archerny archerny commented Oct 20, 2022

Which issue does this PR close?

Closes #324

Rationale for this change

Version field of Cargo.toml is inconsistent with current release.
Member packages of the workspace has its own version, keys like this should not be maintained separately.

What changes are included in this PR?

  1. The version field in parent Cargo.toml
  2. Update all Cargo.toml settings in member packages. Keys like version, edition, authors are changed.

Are there any user-facing changes?

Incorrect version.

How does this change test

  1. See the output of build.rs
  2. Pass the CI

Cargo.toml Show resolved Hide resolved
@archerny archerny changed the title fix: set correct version build: set correct version and let sub-package inherit it Oct 20, 2022
@archerny archerny changed the title build: set correct version and let sub-package inherit it build: set correct version and let member packages inherit it Oct 20, 2022
@jiacai2050 jiacai2050 merged commit 7b9eeff into apache:main Oct 20, 2022
@archerny archerny deleted the version branch January 16, 2023 09:10
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version in Cargo.toml is inconsistent with the release
2 participants