refactor: make mq interface simpler. #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiKaiWi
reviewed
Oct 24, 2022
Rachelint
force-pushed
the
make-mq-interface-simpler
branch
from
301dbff
to
d418cf8
Compare
Rachelint
force-pushed
the
make-mq-interface-simpler
branch
from
d418cf8
to
5404c35
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* make mq interface simpler. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
The race's checking should not be done in mq interface level, it should be done in high-level. So I refactor it to make it simpler.
What changes are included in this PR?
Refactor the mq interface and its kafka implemetation.
Are there any user-facing changes?
None.
How does this change test
By new and exist ut.