-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: correct column order #340
Conversation
@dust1 It seems your branch is kinds of stale, please rebase with latest main branch. |
ok |
@dust1 Have you figured out this problem? I can help do some troubleshooting if you will. Don't worry about the time because this pr is not urgent for us. |
thank you @ShiKaiWi 🥰. Maybe I've already done this pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* edit: column order use user define * edit: update commit * fix: some error * fix: key comparableInnternalKey encode * edit: select * fix: insert data compare use primary key * fix: unit test * edit: remote annotation, fix large enum variant * fix * fix: unit test * fix: unit test * fix: project_record_schema_with_key * fix: unit test * edit: more simple code * edit: modification of description
Which issue does this PR close?
Closes #187
Rationale for this change
Table' columns order is not what user define when create table
What changes are included in this PR?
I modified the 'add_key_column' and 'add_normal_column' methods in 'schema.builder' and added 'primary_key_index' to record additional field primary key information.
Of course this affects the subsequent storage logic.
I removed num_key_size from RecordSchemaWithKey and added key_index to confirm the location of the primary key.
The end result:
Are there any user-facing changes?
How does this change test
I change two unit test in schema.rs. in L1597 and L1600, I changed the field validation order, make the order of the fields consistent with the order in which they were created