Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: wal unit tests. #387

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

Rachelint
Copy link
Contributor

Which issue does this PR close?

Closes #386

Rationale for this change

See #386

What changes are included in this PR?

Refactor tests in wal.

Are there any user-facing changes?

None.

How does this change test

They are tests themselves.

@Rachelint Rachelint changed the title refactor: wal integration test. refactor: wal unit tests. Nov 10, 2022
@Rachelint Rachelint force-pushed the refactor-wal-integration-test branch 2 times, most recently from ba96570 to a919998 Compare November 10, 2022 02:52
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 2059498 into apache:main Nov 10, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@Rachelint Rachelint deleted the refactor-wal-integration-test branch May 27, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test in wal module can be more extensible
2 participants