-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hybrid storage encode bug in multi record batch #426
Conversation
@chunshao90 I think of one critical issue for hybrid format: it will not be compatible with bloom filter. We built bloom filter for each row group, there will be exact The problem is that hybrid storage will shorten rows in one row group, for example if we set |
I create an issue #435. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: fix hybridstorage ecode bug in multi record batch * cargo fmt * refactor code * refactor by CR
Which issue does this PR close?
Closes #403
Rationale for this change
Fix bugs described in #403 .
Hybrid storage compresses multi-record batches into one record batch.
There is a bug where
collapsible_col_arrays
inTsidBatch
only stores the first record batch data, other record batch data are lost.What changes are included in this PR?
Are there any user-facing changes?
No.
How does this change test
Modify some tests to cover this bug.