Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return schema not found when schema not exists #439

Merged
merged 2 commits into from
Dec 1, 2022
Merged

chore: return schema not found when schema not exists #439

merged 2 commits into from
Dec 1, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Dec 1, 2022

Which issue does this PR close?

Closes #

Rationale for this change

When query a not existed schema(tenant), the server will return table not found response which is confusing.

What changes are included in this PR?

Return schema not found when schema(tenant) not exists.

Are there any user-facing changes?

Return schema not found when schema(tenant) not exists.

How does this change test

@chunshao90 chunshao90 changed the title chore: return schema not found when schmea not exists chore: return schema not found when schema not exists Dec 1, 2022
sql/src/provider.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 15a9908 into apache:main Dec 1, 2022
Rachelint pushed a commit to Rachelint/ceresdb that referenced this pull request Dec 2, 2022
* chore: return schema not found when shcmea not exists

* refactor by CR
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* chore: return schema not found when shcmea not exists

* refactor by CR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants