feat: impl parallel get_byte_ranges for ObjectStoreReader #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Dec 5, 2022
ShiKaiWi
reviewed
Dec 6, 2022
ShiKaiWi
reviewed
Dec 7, 2022
jiacai2050
reviewed
Dec 7, 2022
analytic_engine/src/sst/metrics.rs
Outdated
| pub static ref SST_GET_RANGE_HISTOGRAM: Histogram = register_histogram!( | ||
| "sst_get_range_length", | ||
| "Histogram for sst get range length", | ||
| vec!(100.0, 500.0, 1024.0, 1024.0 * 5.0, 1024.0 * 100.0, 1024.0 * 1000.0 * 5.0, 1024.0 * 1000.0 * 1000.0, 1024.0 * 1000.0 * 1000.0 * 5.0) |
There was a problem hiding this comment.
https://docs.rs/prometheus/latest/prometheus/fn.exponential_buckets.html
exponential_buckets（100, 2, 10);
This range cover [100B, 2K), this is enough for rowgroup with 8192 rows.
chunshao90
added a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* feat: impl parallel get_byte_ranges for ObjectStoreReader * chore: add sst_get_range_length_histogram in ObjectStoreReader * fix ci * refactor by CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
The default implementation of
get_byte_rangesinAsyncFileReaderis sequentially.Refer to: https://github.com/apache/arrow-rs/blob/99ced481308e870f69792e49cd23a529fa3ccc70/parquet/src/arrow/async_reader.rs#L124-L140
What changes are included in this PR?
get_byte_rangesusingget_rangesinObjectStore.get_range.Are there any user-facing changes?
No.
How does this change test
Manual testing.