Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: define remote_engine grpc service #505

Merged
merged 2 commits into from
Dec 25, 2022
Merged

chore: define remote_engine grpc service #505

merged 2 commits into from
Dec 25, 2022

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Dec 22, 2022

Which issue does this PR close?

Closes #

Rationale for this change

In the process of implementing the partition table, remote calls between ceresdb-server are involved.
So remote_engine grpc service is needed.

What changes are included in this PR?

Define remote_engine grpc service.

Are there any user-facing changes?

No.

How does this change test

No need.

proto/protos/remote_engine.proto Outdated Show resolved Hide resolved
proto/protos/remote_engine.proto Show resolved Hide resolved
@chunshao90 chunshao90 marked this pull request as ready for review December 25, 2022 09:23
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 6139d89 into apache:main Dec 25, 2022
ShiKaiWi added a commit that referenced this pull request Dec 27, 2022
* refactor: separate object store from parquet sst async reader (#503)

* refactor: separate object store from parquet sst async reader

* fix errors in unit tests

* use const FOOTER_LEN

* add GenericResult

* refactor: recovery in standalone mode (#414)

* refactor recovery in standalone mode.

* make getting table infos dynamically.

* define `LocalTablesRecoverer`.

* address CR.

* feat: support parse key partition (#506)

* add key partition parser

* refactor the codes

* add unit test

* fix show create table for partition table

* address CR issues

* supplement the error msg when fail to parse partition key

* fix unit tests

Co-authored-by: CooooolFrog <zuliangwanghust@gmail.com>

* chore: define remote_engine grpc service (#505)

Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>

* feat: impl key partition rule (#507)

* impl key partition rule(draft).

* refactor to more extensible and testable version.

* add tests for key partition.

* add df adapter and partition rule's building.

* address CR.

Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Co-authored-by: CooooolFrog <zuliangwanghust@gmail.com>
Co-authored-by: chunshao.rcs <chunshao.rcs@antgroup.com>
chunshao90 added a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
Co-authored-by: kamille <34352236+Rachelint@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants