Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Impl remote sdk #509

Merged
merged 7 commits into from
Dec 28, 2022
Merged

feat: Impl remote sdk #509

merged 7 commits into from
Dec 28, 2022

Conversation

Rachelint
Copy link
Contributor

@Rachelint Rachelint commented Dec 26, 2022

Which issue does this PR close?

Closes #
Part of #492

Rationale for this change

For implementing table partition, we supported grpc service about table engine in server.
For calling the service, we need a client.

What changes are included in this PR?

  • move router in server crate to a dependent crate
  • implement the client for remote table engine service

Are there any user-facing changes?

None.

How does this change test

Test manually.

@Rachelint Rachelint marked this pull request as ready for review December 27, 2022 16:04
Cargo.toml Outdated Show resolved Hide resolved
common_types/src/request_id.rs Outdated Show resolved Hide resolved
table_engine/src/remote/model.rs Outdated Show resolved Hide resolved
@Rachelint Rachelint force-pushed the impl-remote-sdk branch 8 times, most recently from 8d9c745 to 24c562f Compare December 28, 2022 05:13
remote_engine_client/src/config.rs Show resolved Hide resolved
table_engine/Cargo.toml Outdated Show resolved Hide resolved
table_engine/Cargo.toml Outdated Show resolved Hide resolved
table_engine/src/predicate.rs Outdated Show resolved Hide resolved
table_engine/src/predicate.rs Outdated Show resolved Hide resolved
table_engine/src/remote/model.rs Outdated Show resolved Hide resolved
table_engine/src/remote/model.rs Outdated Show resolved Hide resolved
table_engine/src/remote/model.rs Outdated Show resolved Hide resolved
remote_engine_client/src/client.rs Outdated Show resolved Hide resolved
remote_engine_client/src/client.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 merged commit 3b21fd1 into apache:main Dec 28, 2022
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
* move router from server to a dependent crate.

* move avro util to common util.

* impl remote sdk.

* modfiy global Cargo.toml and Cargo.lock.

* rename some variable.

* address CR.
@Rachelint Rachelint deleted the impl-remote-sdk branch May 27, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants