-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Impl remote sdk #509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 26, 2022 13:33
683824a
to
b4f42a3
Compare
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 27, 2022 14:07
b4f42a3
to
139e71c
Compare
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 27, 2022 14:17
139e71c
to
e4dada6
Compare
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 27, 2022 16:13
cea2a04
to
217429c
Compare
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 27, 2022 16:16
217429c
to
ea907be
Compare
chunshao90
reviewed
Dec 27, 2022
Rachelint
force-pushed
the
impl-remote-sdk
branch
8 times, most recently
from
December 28, 2022 05:13
8d9c745
to
24c562f
Compare
chunshao90
reviewed
Dec 28, 2022
Rachelint
force-pushed
the
impl-remote-sdk
branch
from
December 28, 2022 08:09
24c562f
to
698d60b
Compare
chunshao90
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
* move router from server to a dependent crate. * move avro util to common util. * impl remote sdk. * modfiy global Cargo.toml and Cargo.lock. * rename some variable. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Part of #492
Rationale for this change
For implementing table partition, we supported grpc service about table engine in server.
For calling the service, we need a client.
What changes are included in this PR?
router
in server crate to a dependent crateAre there any user-facing changes?
None.
How does this change test
Test manually.