feat: prevent from pushing down filter of non primary key or ts key #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #611 +/- ##
==========================================
+ Coverage 62.61% 66.00% +3.38%
==========================================
Files 326 285 -41
Lines 50232 44392 -5840
==========================================
- Hits 31454 29301 -2153
+ Misses 18778 15091 -3687
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
f8b0215
to
0df3d89
Compare
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
0df3d89
to
915f3ff
Compare
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
915f3ff
to
2ba7106
Compare
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
2ba7106
to
d008bfd
Compare
ShiKaiWi
reviewed
Feb 7, 2023
jiacai2050
reviewed
Feb 7, 2023
ShiKaiWi
changed the title
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
5890648
to
5fba237
Compare
jiacai2050
reviewed
Feb 7, 2023
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
3 times, most recently
from
64a1582
to
3364b2c
Compare
Rachelint
force-pushed
the
prevent-to-pushdown-non-pk
branch
from
3364b2c
to
50821d1
Compare
MichaelLeeHZ
pushed a commit
to MichaelLeeHZ/ceresdb
that referenced
this pull request
Feb 8, 2023
…pache#611) * prevent to push down filter of non primary key or ts key. * add test. * address CR.
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
…pache#611) * prevent to push down filter of non primary key or ts key. * add test. * address CR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #605
Rationale for this change
See #605
What changes are included in this PR?
Check if the column in push down filter is primary key or ts key, if not prevent to pass such filter to table scan.
Are there any user-facing changes?
None.
How does this change test
Test by ut.