-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove cluster version #669
refactor: remove cluster version #669
Conversation
84509d1
to
8af6247
Compare
2974503
to
c9294f6
Compare
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
- Coverage 67.55% 67.47% -0.09%
==========================================
Files 281 282 +1
Lines 44343 44309 -34
==========================================
- Hits 29956 29896 -60
- Misses 14387 14413 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor: remove version of region in WAL * refactor: set up server * refactor: setup procedure * refactor: fix unit test * chore: rename context to build context * fix: avoid wal dropped when reopen * chore: avoid useless config updating in ut * fix: wrong config for test write buffer * fix: implement close region for table-kv based wal * chore: fix missing wals for no meta mode
Which issue does this PR close?
Part of #663
Rationale for this change
Remove the useless cluster version in the WAL location, which is introduced by #442 to solve the problems mentioned in #441.
What changes are included in this PR?
close_region
in theWalManager
trait;close_region
instead of using different cluster version;Wal
s in the top level structs;Are there any user-facing changes?
None.
How does this change test
Existing tests.