Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reserve column case when build plan #901

Merged
merged 3 commits into from
May 18, 2023

Conversation

jiacai2050
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

When build plan for prom query, it will normalize column, but in ceresdb column name is case-sensitive.

What changes are included in this PR?

  • Replace col with ident, which will not do normalization.

Are there any user-facing changes?

No

How does this change test

CI

@jiacai2050 jiacai2050 requested a review from Rachelint May 18, 2023 09:54
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rachelint Rachelint merged commit 344c4b3 into apache:main May 18, 2023
@jiacai2050 jiacai2050 deleted the fix-prom-case branch May 18, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants