refactor: optimize sst iterator and filter build to consume less CPU #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiacai2050
reviewed
Jun 7, 2023
|
Great job 👏 BTW, #965 will further reduce footprint in both mem and cpu for tag string column. |
8 tasks
dust1
pushed a commit
to dust1/ceresdb
that referenced
this pull request
Aug 9, 2023
…pache#975) ## Rationale When doing benchmark, sst iterator and xor filter build cost too much CPU. ## Detailed Changes - Change RowViewOnBatchColumnIter's item from Datum to DatumView ## Test Plan I will do benchmark in my test env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When doing benchmark, sst iterator and xor filter build cost too much CPU.
Detailed Changes
Test Plan
I will do benchmark in my test env.