Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for hashers #979

Merged
merged 1 commit into from
Jun 8, 2023
Merged

test: add test for hashers #979

merged 1 commit into from
Jun 8, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jun 8, 2023 •
edited
Loading

Rationale

Part of #973

Detailed Changes

  • Add UT for stable hasher. (Although DefaultHasher doesn't promise fixed code over rust release, it should be same for fixed rust version.)

Test Plan

ShiKaiWi
ShiKaiWi approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit 5bee59f into apache:main Jun 8, 2023
@jiacai2050 jiacai2050 deleted the test-hasher branch June 8, 2023 09:33
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
@jiacai2050 @dust1
test: add test for hashers (apache#979)
6e872e8 
## Rationale
Part of apache#973

## Detailed Changes
- Add UT for stable hasher. (Although DefaultHasher doesn't promise
fixed code over rust release, it should be same for fixed rust version.)

## Test Plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ShiKaiWi