Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure files can only be picked once #995

Merged
merged 9 commits into from
Jun 19, 2023
Merged

fix: ensure files can only be picked once #995

merged 9 commits into from
Jun 19, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Jun 15, 2023 •
edited
Loading

Rationale

In current design, sst files may be picked multiple times.

Detailed Changes

  • Mark files as in compacting when pick files candidates, and reset it to false when CompactionTask is dropped.

Test Plan

Manually

Rachelint
Rachelint approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@Rachelint Rachelint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit d26e958 into apache:main Jun 19, 2023
MichaelLeeHZ pushed a commit to MichaelLeeHZ/ceresdb that referenced this pull request Jun 21, 2023
@jiacai2050 @MichaelLeeHZ
fix: ensure files can only be picked once (apache#995)
6628639 
## Rationale
In current design, sst files may be picked multiple times.

## Detailed Changes
- Mark files as in compacting when pick files candidates, and reset it
to false when CompactionTask is dropped.

## Test Plan
Manually
dust1 pushed a commit to dust1/ceresdb that referenced this pull request Aug 9, 2023
@jiacai2050 @dust1
fix: ensure files can only be picked once (apache#995)
de623b2 
## Rationale
In current design, sst files may be picked multiple times.

## Detailed Changes
- Mark files as in compacting when pick files candidates, and reset it
to false when CompactionTask is dropped.

## Test Plan
Manually
@jiacai2050 jiacai2050 deleted the fix-compact branch November 22, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi left review comments

@Rachelint Rachelint Rachelint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiacai2050 @ShiKaiWi @Rachelint