Skip to content

P2 Feature request: add a unit test to guard against incorrect key data structure change #1279

@dentiny

Description

@dentiny

Is your feature request related to a problem or challenge?

The title for the feature request might be confusion, I will explain more here.

The motivation comes from #1276;
When I was working on the PR to sync upstream iceberg spec change to our rust sdk, I find I have to propagate the schema change to multiple places.

Describe the solution you'd like

I think there're usually two ways to solve the problem:

  • Use codegen to generate schema related changes
    • Example-1: bazel supports proto_library, which auto-generates protobuf files with one single bazel build
    • Example-2: kuberay auto-generates grpc client code, http client code and swagger json
  • Another way is to add unit tests
    • For example, these two (1, 2) data structures should be consistent with each other, otherwise compilation fails, but new fields won't be persisted into manifest file

Willingness to contribute

I would be willing to contribute to this feature with guidance from the Iceberg Rust community

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions