feat: Add deletion vector related fields in spec types #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
changed the title
Member
|
Hi @dentiny, I have updated the PR title to better reflect the changes. I have to say that I completely agree with your "upstream first" philosophy, and I appreciate any kind of help. Welcome to join the community! |
Xuanwo
previously approved these changes
Apr 30, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Most changes look good me.
Do you have other concerns? @Fokko @liurenjie1024 @sdd
dentiny
changed the title
Contributor
Author
|
Sorry there're some test compilation failures, let me fix them. |
dentiny
commented
Apr 30, 2025
| equality_ids: vec![], | ||
| sort_order_id: None, | ||
| partition_spec_id: 0, | ||
| referenced_data_file: None, |
Contributor
Author
There was a problem hiding this comment.
The reason I manually assigned these fields is to keep coding style consistency.
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr, generally a good start for building v3 support. Just one minor hint.
Xuanwo
changed the title
liurenjie1024
approved these changes
May 1, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr!
dentiny
added a commit
to dentiny/iceberg-rust
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR sync up with upstream iceberg spec on deletion vector related fields.
Reference PR: apache/iceberg#11240
Reference file: https://github.com/apache/iceberg/blob/main/format/spec.md#manifests
Context:
I'm working on iceberg related projects in my work, one of the features I'm working on is deletion vector.
Because there's no existing rust support for it, I need to do some of the work my own (i.e. deletion vector read and write).
My philosophy is to reduce discrepancy with upstream is:
I personally think the schema change alone (without actual deletion vector feature implementation) make sense, because it's a sync-up from iceberg spec sync (which has already been acknowledged by the community), as the PR.
I'm happy to discuss more on this PR, I'm willing to provide more on the motivation, my work-around and followup;
I'm also willing to contribute if the community requires more hands on it.
Are these changes tested?
This PR is a no-op change, I confirm I could build + link with no problem.