chore: Expose puffin blob constructor #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentiny
changed the title
crates/iceberg/src/puffin/blob.rs
Outdated
| self | ||
| } | ||
|
|
||
| pub fn build(self) -> Blob { |
Contributor
There was a problem hiding this comment.
This is incorrect. For fields that are required, we should need to check if they are set. You can use TypedBuilder to help to ensure safety.
Contributor
Author
There was a problem hiding this comment.
got it, thanks for the lesson!
liurenjie1024
approved these changes
May 14, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @dentiny for this pr, LGTM!
Contributor
Author
Thank you for the great help! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR expose public construction function for puffin blob, as discussed in the linked issue.
The main motivation is: puffin blob is supposed to hold any type, so should be public-ly accessible by developers.
blobstruct public #1311Are these changes tested?
This PR is a no-op change, I verified compilation passes through on my end.