Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Storage support to relative local FS paths #712

Closed
wants to merge 1 commit into from

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Nov 22, 2024

Closes #711.

Add support for relative paths in local FS storage, keeping the rest of the functionality intact. An example how this can be helpful can be seen here https://github.com/splitgraph/seafowl/pull/744/files.

@gruuya gruuya force-pushed the local-fs-relative-paths branch 2 times, most recently from 73fd7ac to 91ffd55 Compare November 22, 2024 12:29
@Fokko
Copy link
Contributor

Fokko commented Nov 22, 2024

Hey @gruuya Thanks for creating this PR. Unfortunately, Iceberg does not support relative paths. There is a long open issue apache/iceberg#1617 but it is pretty complex to implement. As an example, merge-on-read uses absolute paths to know which files to apply the deletes to. Adding support for relative paths makes this very brittle since the path might not be matched correctly, resulting in data correctness issues.

Instead, for testing, I would suggest symlinking similar to what I did in pola-rs/polars#10375 or running a MinIO S3 container, similar to the integration tests of iceberg-rust itself: https://github.com/apache/iceberg-rust/blob/main/crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml

@gruuya
Copy link
Contributor Author

gruuya commented Nov 22, 2024

Oh I see, didn't realize it was prohibited at the spec level. Thanks, closing.

@Fokko
Copy link
Contributor

Fokko commented Nov 22, 2024

@gruuya No worries, thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support relative paths in Storage::LocalFs
2 participants