chore: Bump upload-artifact@v3 to v4

[sungwy]

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

ACTION REQUIRED notice on mailing list: https://lists.apache.org/thread/nx19j3h61tjmsk8c8vx24gbq6ygf7pyf

[kevinjqliu]

is it possible to test this on your action on your fork?

[kevinjqliu]

should this also be changed to

        name: wheels-*
        merge-multiple: true

[sungwy]

great catch!

[sungwy]

is it possible to test this on your action on your fork?

I think the easier way would be for me to test it against this repository using the pull_request trigger by temporarily commenting out the testpypi-publish condition. I'm catching a few bugs testing this out :) Thanks for the suggestion!

[sungwy]

@kevinjqliu - please refer to: https://test.pypi.org/manage/project/pyiceberg-core/release/0.1.0/

[kevinjqliu]

nice! I see it at https://test.pypi.org/project/pyiceberg-core/

and I was able to install it locally

poetry run pip install -i https://test.pypi.org/simple/ pyiceberg-core
poetry run python

import pyiceberg_core
dir(pyiceberg_core)

Built Distributions looks correct:
https://test.pypi.org/project/pyiceberg-core/#files

[kevinjqliu]

thanks for adding this!

[sungwy]

thanks for adding this!

@kevinjqliu Thanks for the review! :)

[liurenjie1024]

LGTM, but better waiting for @Xuanwo and @Fokko to take a review since I'm not familiar with python distribution.

[Xuanwo]

Thank you @sungwy, love it! Also thank you @kevinjqliu and @liurenjie1024 for review.