Core: Remove unused method accidentally added to TableMetadata #4155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
approved these changes
Feb 17, 2022
rdblue
requested changes
Feb 17, 2022
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
I don't think this should remove addStagedSnapshot or replaceCurrentSnapshot(Snapshot) because 0.13.1 is a patch release. It's okay to remove them in master, but I wouldn't do it here. Instead, I'd say we should only remove the method that was accidentally added.
wypoon
force-pushed
the
4135_followup
branch
from
d1d64b8 to
a409048
Compare
wypoon
changed the title
Contributor
Author
Restored those methods. Only remove the one added by #4135. |
rdblue
approved these changes
Feb 17, 2022
Contributor
|
Thanks, @wypoon! |
aokolnychyi
approved these changes
Feb 18, 2022
vanliu-tx
pushed a commit
to BKBASE-Plugin/iceberg
that referenced
this pull request
Mar 30, 2022
samarthjain
pushed a commit
to samarthjain/incubator-iceberg
that referenced
this pull request
Apr 6, 2022
vanliu-tx
pushed a commit
to BKBASE-Plugin/iceberg
that referenced
this pull request
May 11, 2022
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4135 fixed a regression in 0.13.x by porting part of #4089, but accidentally added an unused method to
TableMetadata. We remove it in this follow-up.