From 607c28977aa6e410312a670907a94a3a3d06ce02 Mon Sep 17 00:00:00 2001 From: Kyle Bendickson Date: Wed, 15 Jun 2022 12:54:27 -0700 Subject: [PATCH 1/3] Core: Fix Error Prone warnings for REST Catalog request / respoonses --- .../org/apache/iceberg/rest/requests/RenameTableRequest.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java b/core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java index 9f7c42b715ad..c3430baec584 100644 --- a/core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java +++ b/core/src/main/java/org/apache/iceberg/rest/requests/RenameTableRequest.java @@ -43,6 +43,7 @@ private RenameTableRequest(TableIdentifier source, TableIdentifier destination) validate(); } + @Override public void validate() { Preconditions.checkArgument(source != null, "Invalid source table: null"); Preconditions.checkArgument(destination != null, "Invalid destination table: null"); From 8e9718c504ba65d8158af69cd07917b41c9a05f2 Mon Sep 17 00:00:00 2001 From: Kyle Bendickson Date: Wed, 15 Jun 2022 12:55:13 -0700 Subject: [PATCH 2/3] Add private constructor for static builder --- .../org/apache/iceberg/rest/responses/OAuthTokenResponse.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java b/core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java index fdda034722c5..239aa3ee476c 100644 --- a/core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java +++ b/core/src/main/java/org/apache/iceberg/rest/responses/OAuthTokenResponse.java @@ -80,6 +80,9 @@ public static class Builder { private Integer expiresInSeconds; private final List scopes = Lists.newArrayList(); + private Builder() { + } + public Builder withToken(String token) { this.accessToken = token; return this; From 6512e11d8576261a279527cc61968cd6ba583506 Mon Sep 17 00:00:00 2001 From: Kyle Bendickson Date: Wed, 15 Jun 2022 13:05:12 -0700 Subject: [PATCH 3/3] Add a javadoc for LoadTableResponse, including noting that its used for several responses --- .../apache/iceberg/rest/responses/LoadTableResponse.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java b/core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java index 83da540863f7..d96db0605911 100644 --- a/core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java +++ b/core/src/main/java/org/apache/iceberg/rest/responses/LoadTableResponse.java @@ -28,7 +28,12 @@ import org.apache.iceberg.rest.RESTResponse; /** - * + * A REST response that is used when a table is successfully loaded. + *

+ * This class is used whenever the response to a request is a table's requested metadata and the associated location + * of its metadata, to reduce code duplication. This includes using this class as the response for + * {@link org.apache.iceberg.rest.requests.CreateTableRequest}, including when that request is used to commit + * an already staged table creation as part of a transaction. */ public class LoadTableResponse implements RESTResponse {