From 5fabb26365b041ffd3ae25656d253d2163f5b906 Mon Sep 17 00:00:00 2001 From: abeizn Date: Fri, 21 Jun 2024 09:20:44 +0800 Subject: [PATCH 1/2] fix: pr reviewers and assignees script version error --- .../20240531_add_pr_assignees_and_reviewers.go | 2 +- ...0240607_modify_pr_assignees_and_reviewers_id.go | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/backend/core/models/migrationscripts/20240531_add_pr_assignees_and_reviewers.go b/backend/core/models/migrationscripts/20240531_add_pr_assignees_and_reviewers.go index fa852c96078..d7cbd9f9faf 100644 --- a/backend/core/models/migrationscripts/20240531_add_pr_assignees_and_reviewers.go +++ b/backend/core/models/migrationscripts/20240531_add_pr_assignees_and_reviewers.go @@ -35,7 +35,7 @@ func (u *addPrAssigneeAndReviewer) Up(basicRes context.BasicRes) errors.Error { } func (*addPrAssigneeAndReviewer) Version() uint64 { - return 20250531000041 + return 20240531000041 } func (*addPrAssigneeAndReviewer) Name() string { diff --git a/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go b/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go index adfe318ed91..ad8f890cdb7 100644 --- a/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go +++ b/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go @@ -28,7 +28,17 @@ type modifyPrAssigneeAndReviewerId struct{} func (u *modifyPrAssigneeAndReviewerId) Up(basicRes context.BasicRes) errors.Error { db := basicRes.GetDal() - err := db.DropTables(&archived.PullRequestAssignee{}, &archived.PullRequestReviewer{}) + err := db.Exec(`delete from _devlake_migration_history + where script_version="20250531000041" and script_name="add pull_request_reviewers and pull_request_assignees tables"`) + if err != nil { + return err + } + err = db.Exec(`delete from _devlake_migration_history + where script_version="20250607000041" and script_name="modify pull_request_reviewers and pull_request_assignees id columns"`) + if err != nil { + return err + } + err = db.DropTables(&archived.PullRequestAssignee{}, &archived.PullRequestReviewer{}) if err != nil { return err } @@ -40,7 +50,7 @@ func (u *modifyPrAssigneeAndReviewerId) Up(basicRes context.BasicRes) errors.Err } func (*modifyPrAssigneeAndReviewerId) Version() uint64 { - return 20250607000041 + return 20240607000041 } func (*modifyPrAssigneeAndReviewerId) Name() string { From fea2de0a77e186d64cf2e8a77abefb1c9bb7b2d7 Mon Sep 17 00:00:00 2001 From: abeizn Date: Fri, 21 Jun 2024 09:28:45 +0800 Subject: [PATCH 2/2] fix: adapt pg test --- .../20240607_modify_pr_assignees_and_reviewers_id.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go b/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go index ad8f890cdb7..3d144d3b485 100644 --- a/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go +++ b/backend/core/models/migrationscripts/20240607_modify_pr_assignees_and_reviewers_id.go @@ -29,12 +29,12 @@ type modifyPrAssigneeAndReviewerId struct{} func (u *modifyPrAssigneeAndReviewerId) Up(basicRes context.BasicRes) errors.Error { db := basicRes.GetDal() err := db.Exec(`delete from _devlake_migration_history - where script_version="20250531000041" and script_name="add pull_request_reviewers and pull_request_assignees tables"`) + where script_version='20250531000041' and script_name='add pull_request_reviewers and pull_request_assignees tables'`) if err != nil { return err } err = db.Exec(`delete from _devlake_migration_history - where script_version="20250607000041" and script_name="modify pull_request_reviewers and pull_request_assignees id columns"`) + where script_version='20250607000041' and script_name='modify pull_request_reviewers and pull_request_assignees id columns'`) if err != nil { return err }